Skip to content

Fix jerry_get_context_data() API function #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

Fix jerry_get_context_data() API function #3127

merged 1 commit into from
Sep 17, 2019

Conversation

ossy-szeged
Copy link
Contributor

If manager_p->bytes_needed == 0, jerry_get_context_data() should return
NULL pointer. Additionally init_cb, deinit_cb and finalize_cb should be
called with NULL pointer in this case.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]

@ossy-szeged
Fix jerry_get_context_data() API function
908b48f 
If manager_p->bytes_needed == 0, jerry_get_context_data() should return
NULL pointer. Additionally init_cb, deinit_cb and finalize_cb should be
called with NULL pointer in this case.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]
@ossy-szeged ossy-szeged force-pushed the fix-jerry_get_context_data branch from bf5e8b2 to 908b48f Compare September 16, 2019 20:34
rerobika
rerobika approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbatyai
dbatyai approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit c05686b into jerryscript-project:master Sep 17, 2019
@ossy-szeged ossy-szeged deleted the fix-jerry_get_context_data branch September 17, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbatyai dbatyai dbatyai approved these changes

@rerobika rerobika rerobika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ossy-szeged @dbatyai @rerobika